Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom success message for ExtractionPipelineRun #276

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

redzaroslii
Copy link
Contributor

Modify Extractor base class for success_message option that is passed as an input to ExtractionPipelineRun() when a run is successful

@redzaroslii redzaroslii requested a review from a team as a code owner December 19, 2023 16:31
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.22%. Comparing base (e8b1783) to head (ca1f9d7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   75.19%   75.22%   +0.03%     
==========================================
  Files          42       42              
  Lines        3495     3496       +1     
==========================================
+ Hits         2628     2630       +2     
+ Misses        867      866       -1     
Files with missing lines Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/base.py 49.46% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

einarmo
einarmo previously approved these changes Jan 4, 2024
Copy link
Contributor

@einarmo einarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mathialo mathialo requested a review from a team February 24, 2025 09:24
@mathialo mathialo requested review from a team and BugGambit and removed request for a team February 24, 2025 13:06
@mathialo mathialo merged commit 050b6fe into master Feb 24, 2025
7 checks passed
@mathialo mathialo deleted the feat/custom-success-message branch February 24, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants